Skip to content

feat(copilot): claude-4 llm model support #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

feat(copilot): claude-4 llm model support #1948

merged 1 commit into from
Jun 25, 2025

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

image

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added this to the v1.12.0 milestone Jun 25, 2025
@ysfscream ysfscream requested review from Red-Asuka and Copilot June 25, 2025 06:19
@ysfscream ysfscream self-assigned this Jun 25, 2025
@ysfscream ysfscream added enhancement New feature or request feature This pr is a feature desktop MQTTX Desktop labels Jun 25, 2025
@ysfscream ysfscream added this to MQTTX Jun 25, 2025
@ysfscream ysfscream moved this to In Progress in MQTTX Jun 25, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for new Claude LLM models (claude-opus-4 and claude-sonnet-4 variants) by updating the provider options and associated tests.

  • Updated tests to verify the inclusion of new model identifiers under the Anthropic provider.
  • Expanded the list of available models in the provider options to include new Claude variants.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/unit/utils/ai/copilot.spec.ts Updated tests to check for the new Claude model identifiers under the Anthropic provider.
src/utils/ai/copilot.ts Added new model entries for Claude LLM variants and adjusted existing ones for consistency.
Comments suppressed due to low confidence (2)

tests/unit/utils/ai/copilot.spec.ts:76

  • The test expectations have been updated to include the new Claude models; please confirm that these identifiers match the intended provider configuration and that any downstream impact on model selection logic is covered by tests.
      expect(anthropic?.children.map((c) => c.value)).to.include('claude-opus-4-20250514')

src/utils/ai/copilot.ts:134

  • The update replaces the previous 'claude-3-5-sonnet-latest' with 'claude-3-7-sonnet-latest', but later in the diff 'claude-3-5-sonnet-latest' is reintroduced. Please verify that both model identifiers are required and clearly differentiated, or consider adding inline comments to clarify their distinct purposes.
      { value: 'claude-3-7-sonnet-latest' },

@Red-Asuka Red-Asuka merged commit d27d8c4 into main Jun 25, 2025
4 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch June 25, 2025 06:32
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQTTX Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants