Skip to content

fix(desktop): fix sys scrollbar style issue for win #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

image

Issue Number

Example: #123

What is the new behavior?

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added this to the v1.12.0 milestone Jun 25, 2025
@ysfscream ysfscream requested review from Red-Asuka and Copilot June 25, 2025 06:00
@ysfscream ysfscream self-assigned this Jun 25, 2025
@ysfscream ysfscream added fix Fix bug or issues UI/UX Improve some UI \ UX labels Jun 25, 2025
@ysfscream ysfscream added this to MQTTX Jun 25, 2025
@ysfscream ysfscream added desktop MQTTX Desktop Windows labels Jun 25, 2025
@ysfscream ysfscream moved this to In Progress in MQTTX Jun 25, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a Windows-specific issue with system scrollbar styling by modifying the overflow behavior in UI components.

  • Updated overflow properties in CopilotMessages.vue to use "overflow-x: unset" and "overflow-y: scroll"
  • Added "overflow-y: scroll" in MessageList.vue and removed redundant scrolling properties

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/ai/CopilotMessages.vue Adjusts scrollbar overflow handling to fix display issues on Windows
src/components/MessageList.vue Adds overflow-y scrolling while removing redundant overflow declarations
Comments suppressed due to low confidence (2)

src/components/ai/CopilotMessages.vue:183

  • Consider verifying that 'overflow-x: unset' provides consistent behavior across different Windows environments. If cross-browser consistency is required, an explicit value may be preferable.
    overflow-x: unset;

src/components/MessageList.vue:141

  • [nitpick] Ensure that using 'overflow-y: scroll' does not cause unwanted scrollbars in cases where the content height is less than the container height.
  overflow-y: scroll;

@Red-Asuka Red-Asuka merged commit 9e156c3 into main Jun 25, 2025
4 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch June 25, 2025 06:05
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQTTX Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop fix Fix bug or issues UI/UX Improve some UI \ UX Windows
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants