Skip to content

refactor(background): enable devTools in BrowserWindow configuration #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented May 20, 2025

PR Checklist

For any questions, see our Contributing Guide

Current Behavior

DevTools are disabled by default in both development and production builds.
When a white screen or rendering error occurs, contributors cannot open the console, inspect network traffic, or profile performance, making root-cause analysis slow and screenshot-dependent.

Issue Number

Fixes:

New Behavior

  • Production builds keep the shortcut Ctrl + Shift + I / Cmd + Opt + I to allow on-site debugging.
image

Breaking Changes?

  • Yes
  • No

Other Information

  • DevTools load only when explicitly enabled, so default performance and bundle size remain unchanged.
  • A future improvement could capture console.error messages and upload them automatically, reducing manual log collection.

@ysfscream ysfscream added this to the v1.12.0 milestone May 20, 2025
@ysfscream ysfscream requested review from Red-Asuka and Copilot May 20, 2025 16:25
@ysfscream ysfscream self-assigned this May 20, 2025
@ysfscream ysfscream added enhancement New feature or request refactor Refactor code or architecture labels May 20, 2025
@ysfscream ysfscream added this to MQTTX May 20, 2025
@ysfscream ysfscream added the desktop MQTTX Desktop label May 20, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the BrowserWindow configuration to always enable DevTools, allowing debugging shortcuts in production when desired.

  • Changed devTools setting from conditional (isDevelopment) to always true
  • Simplifies on-site debugging for rendering or performance issues

@ysfscream ysfscream moved this to In Progress in MQTTX May 20, 2025
@Red-Asuka Red-Asuka merged commit b41ee06 into main May 21, 2025
4 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch May 21, 2025 05:50
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQTTX May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request refactor Refactor code or architecture
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants