fix(ci): update artifact upload process to use gitHub release #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CI workflow to upload artifacts using GitHub Releases instead of a custom script, and adjusts the S3 upload process accordingly. Additionally, it updates the download URL in vue.config.js to point to the new location.
- Replaces custom GitHub asset upload with softprops/action-gh-release in both Linux and Windows build jobs.
- Changes the tag extraction to use github.ref_name and modifies the S3 copy command.
- Updates the download URL in vue.config.js.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build_packages.yaml | Updates CI steps to use GitHub Releases for artifact uploads and adjusts S3 upload commands using github.ref_name. |
| vue.config.js | Updates the generic provider URL for downloads. |
Red-Asuka
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/emqx/MQTTX/actions/runs/14090127644