fix(desktop): fix can not past content on monaco editor #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the clipboard paste functionality in Monaco Editor on Electron by patching the editor's clipboard code. Key changes include:
- Adding a patch script (patch-monaco-clipboard.js) that removes the platform.isWeb check.
- Updating the postinstall script to run the patch automatically.
- Extending the documentation in README.md with details about the patch.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/patch-monaco-clipboard.js | Removes the platform.isWeb check in Monaco's clipboard code and adds patch comments. |
| scripts/README.md | Documents the patch scripts and their usage for improving clipboard behavior in Electron. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
scripts/patch-monaco-clipboard.js:22
- [nitpick] The regular expression used for replacing the platform.isWeb check is very strict. Consider using a more flexible pattern (e.g., accommodating variable whitespace) to ensure that changes in formatting do not break the patch.
if (!result && platform.isWeb) {
scripts/patch-monaco-clipboard.js:6
- [nitpick] The comment references multiple GitHub issues, including an outdated one (1046); consider consolidating the references to focus on the primary relevant issue (microsoft/monaco-editor#4855) to avoid confusion.
* - https://github.com/microsoft/monaco-editor/issues/1046
Red-Asuka
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Monaco Editor's clipboard functionality, especially paste, doesn't work properly in Electron environments. The issue occurs because Monaco checks for
platform.isWebbefore using the clipboard service as a fallback whendocument.execCommand('paste')fails. Since Electron isn't detected as a web platform (despite running in a Chromium environment), the clipboard functionality fails.This issue became more critical with Electron, where
execCommand('paste')support was dropped entirely, making paste functionality unusable in the Monaco Editor.Issue Number
Related to microsoft/monaco-editor#4855
What is the new behavior?
This PR adds a patch script that removes the
platform.isWebcheck in Monaco Editor's clipboard implementation, allowing the clipboard service to be used in Electron environments. The patch is applied automatically after dependency installation.Specifically:
patch-monaco-clipboard.jsscript that modifies the Monaco clipboard codepostinstallscript to run this patch after dependencies are installedMonaco Editor's paste functionality works properly in MQTTX when running in Electron with this patch.
Does this PR introduce a breaking change?
Specific Instructions
After merging this PR, anyone who installs dependencies will automatically get the patched version of Monaco Editor. If anyone is experiencing clipboard issues with Monaco Editor in the application, they should run:
This will reapply the patch and fix the issue.