Skip to content

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Sep 23, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

#1762 (comment)

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #1762

What is the new behavior?

  • Rename addExtension to checkExtension for clarity
  • Implement logic to remove incorrect extensions before adding the correct one
  • Handle cases where the file already has the correct extension
  • Improve code readability and maintainability

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream self-assigned this Sep 23, 2024
@ysfscream ysfscream added fix Fix bug or issues desktop MQTTX Desktop labels Sep 23, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Sep 23, 2024
@ysfscream ysfscream merged commit 80a3dd0 into main Sep 24, 2024
2 checks passed
@ysfscream ysfscream deleted the ysf/desktop branch September 24, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop fix Fix bug or issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants