Skip to content

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Sep 5, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

image

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added CLI MQTTX CLI test labels Sep 5, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Sep 5, 2024
@ysfscream ysfscream requested a review from Red-Asuka September 5, 2024 09:30
@ysfscream ysfscream self-assigned this Sep 5, 2024
@ysfscream ysfscream marked this pull request as draft September 5, 2024 10:02
@ysfscream ysfscream marked this pull request as ready for review September 6, 2024 03:42
@Red-Asuka
Copy link
Member

@ysfscream The CI raised a warning about unreleased resources. Do we need to address this?

image

@ysfscream
Copy link
Member Author

@Red-Asuka YES, but debugging and tracing the issue under CI is hard. An unkilled process causes it. It works fine on my local machine, so we can let it be for now. There's no significant impact at present.

@Red-Asuka Red-Asuka merged commit b926c74 into main Sep 6, 2024
6 checks passed
@Red-Asuka Red-Asuka deleted the ysf/cli_test branch September 6, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants