Skip to content

feat(desktop): skip cli version check on windows #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat(desktop): skip cli version check on windows #1718

merged 2 commits into from
Jul 10, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Jul 10, 2024 •
edited
Loading

  1. Windows cannot execute mqttx cli on the terminal, making it hard to check the current mqttx CLI version, so we skip the check directly.
  2. Users need to manually download the mqttx CLI on Windows, allowing them to select the download path to use mqttx.exe.

@ysfscream ysfscream added enhancement New feature or request desktop MQTTX Desktop labels Jul 10, 2024
@ysfscream ysfscream added this to the v1.10.1 milestone Jul 10, 2024
@ysfscream ysfscream requested review from Red-Asuka and XL-YiBai July 10, 2024 07:19
@ysfscream ysfscream self-assigned this Jul 10, 2024
@Red-Asuka Red-Asuka merged commit 51f20de into main Jul 10, 2024
@Red-Asuka Red-Asuka deleted the ysf/desktop branch July 10, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Red-Asuka Red-Asuka Red-Asuka approved these changes

+1 more reviewer

@XL-YiBai XL-YiBai XL-YiBai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ysfscream ysfscream

Labels
desktop MQTTX Desktop enhancement New feature or request
Projects
MQTTX
Status: Done
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ysfscream @Red-Asuka @XL-YiBai