Skip to content

fix(cli): fix sub error logic with multi topics #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

fix(cli): fix sub error logic with multi topics #1672

merged 1 commit into from
May 29, 2024

Conversation

ysfscream
Copy link
Member

What is the current behavior?

image

What is the new behavior?

image

Handle individual topic subscription success and failure separately

  • Refactor to use Promise.all for concurrent subscription handling
  • Log each topic's subscription status independently
  • Ensure individual topic failures do not affect others
  • Explicitly define return types for subscription promises
  • Improve performance by reducing redundant checks

Does this PR introduce a breaking change?

  • Yes
  • No

@ysfscream ysfscream added enhancement New feature or request fix Fix bug or issues CLI MQTTX CLI labels May 28, 2024
@ysfscream ysfscream added this to the v1.10.0 milestone May 28, 2024
@ysfscream ysfscream requested a review from Red-Asuka May 28, 2024 16:17
@ysfscream ysfscream self-assigned this May 28, 2024
@Red-Asuka Red-Asuka merged commit 64c35fe into main May 29, 2024
@Red-Asuka Red-Asuka deleted the ysf/cli branch May 29, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Red-Asuka Red-Asuka Red-Asuka approved these changes

Assignees

@ysfscream ysfscream

Labels
CLI MQTTX CLI enhancement New feature or request fix Fix bug or issues
Projects
MQTTX
Status: Done
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ysfscream @Red-Asuka