Skip to content

refactor(cli): improve bench sub logs #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

refactor(cli): improve bench sub logs #1675

merged 1 commit into from
May 29, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented May 29, 2024 •
edited
Loading

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

image

What is the new behavior?

  1. Improved Logging for Multiple Topics: Ensure log messages accurately display all subscribed topics.
  2. Independent Multi-Topic Subscription: Ensure that subscriptions to multiple topics do not interfere with each other.
  3. Effective Error Differentiation: Improve error messages to differentiate between different types of errors.
  4. Display Connection Information: Add functionality to log detailed connection information.
image image

Does this PR introduce a breaking change?

  • Yes
  • No

@ysfscream ysfscream added enhancement New feature or request fix Fix bug or issues refactor Refactor code or architecture CLI MQTTX CLI labels May 29, 2024
@ysfscream ysfscream added this to the v1.10.0 milestone May 29, 2024
@ysfscream ysfscream requested a review from Red-Asuka May 29, 2024 09:43
@ysfscream ysfscream self-assigned this May 29, 2024
@Red-Asuka Red-Asuka merged commit 0b8f8d1 into main May 29, 2024
@Red-Asuka Red-Asuka deleted the ysf/cli branch May 29, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Red-Asuka Red-Asuka Red-Asuka approved these changes

Assignees

@ysfscream ysfscream

Labels
CLI MQTTX CLI enhancement New feature or request fix Fix bug or issues refactor Refactor code or architecture
Projects
MQTTX
Status: Done
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ysfscream @Red-Asuka