Skip to content

feat(cli): add delimiter option for sub file write #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2024
Merged

feat(cli): add delimiter option for sub file write #1645

merged 2 commits into from
May 10, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented May 9, 2024 •
edited
Loading

PR Checklist

What is the current behavior?

Users cannot change the delimiter for writing to a file because the default value is only the '\n.'

What is the new behavior?

{"temp":59,"hum":86}
{"temp":71,"hum":75}
{"temp":36,"hum":40}
{"temp":53,"hum":49}

mqttx bench pub -c 1 -h 127.0.0.1 -t 'smart_home' --file-read ./data-split-newline.txt --split -im 1000
mqttx sub -h 127.0.0.1 -p 1883 -t smart_home --file-write ./delimiter-file.txt --delimiter ','
{"temp":59,"hum":86},{"temp":71,"hum":75},{"temp":36,"hum":40},{"temp":53,"hum":49},

@ysfscream ysfscream added feature This pr is a feature CLI MQTTX CLI labels May 9, 2024
@ysfscream ysfscream added this to the v1.10.0 milestone May 9, 2024
@ysfscream ysfscream requested a review from Red-Asuka May 9, 2024 16:16
@ysfscream ysfscream self-assigned this May 9, 2024
Red-Asuka
Red-Asuka reviewed May 10, 2024
View reviewed changes
@Red-Asuka Red-Asuka merged commit 6a767fe into main May 10, 2024
@Red-Asuka Red-Asuka deleted the ysf/cli branch May 10, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Red-Asuka Red-Asuka Red-Asuka approved these changes

Assignees

@ysfscream ysfscream

Labels
CLI MQTTX CLI feature This pr is a feature
Projects
MQTTX
Status: Done
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ysfscream @Red-Asuka