Get MODULARIZE_INSTANCE working with USE_PTHREADS #8372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
This appears to have never worked, and was not tested. * Ensure _scriptDir exists properly. * Do not instantiate Module(), as this mode does so automatically. * Add a test.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…-core#8372)" This reverts commit a291091.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…-core#8372)" This reverts commit a291091.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
This appears to have never worked, and was not tested. * Ensure _scriptDir exists properly. * Do not instantiate Module(), as this mode does so automatically. * Add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have never worked, and was not tested.
_scriptDirexists properly.Module(), as this mode does so automatically.@sbc100 The openjpeg etc. failures on the wasm backend here look like that PIC stuff that is known to be currently broken, I think?
cc @Brion - perhaps you can test this?