Fix issue with rehydrated style tags not taking into account prepend option #1696
Conversation
🦋 Changeset is good to goLatest commit: 6140fae We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6140fae:
|
packages/sheet/src/index.js
Outdated
| @@ -84,20 +84,27 @@ export class StyleSheet { | |||
| this.before = null | |||
| } | |||
|
|
|||
| _insertTag = (tag = createStyleElement(this)) => { | |||
There was a problem hiding this comment.
This will probably be slightly smaller if we don't do a default arg and instead call it with that where we need to
There was a problem hiding this comment.
Agreed - proposed change is much better.
bae9ffb to
7ef4d11
Compare
Codecov Report
|
7ef4d11 to
c0384ba
Compare
c0384ba to
6140fae
Compare
|
@mitchellhamilton fixed a nit-pick about |
This fixes an issue with rehydrated tags always being appended - regardless of
prependoption.It also makes sheet own "its" rehydrated styles - which seems like a good change, because without that
flushdidn't affect those.