Skip to content

Fix jest-emotion toHaveStyleRule on react.elements #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Fix jest-emotion toHaveStyleRule on react.elements #1406

wants to merge 0 commits into from

Conversation

mabels
Copy link
Contributor

@mabels mabels commented Jun 19, 2019

If the matcher toHaveStyleRules is used on explicit found elements. It does worked befor the fix.

I want to have explict tests like:
expect(tree.find('li').get(0)).toHaveStyleRule('background', 'hello');

packages/jest-emotion/src/utils.js (one line)
packages/jest-emotion/test/react-enzyme.test.js (a regession test)

check

  • [not applicable ] Documentation
  • [x ] Tests
  • [x ] Code complete
  • [not applicable ] Changeset

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2019 •
edited
Loading

💥 No Changeset

Latest commit: e09fb21

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jun 19, 2019 •
edited
Loading

Codecov Report

Merging #1406 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/babel-plugin-emotion/src/emotion-macro.js 90.47% <ø> (ø)
scripts/babel-preset-emotion-dev/src/index.js 100% <ø> (ø) ⬆️
packages/cache/src/index.js 98.9% <ø> (-1.1%) ⬇️
packages/babel-plugin-emotion/src/index.js 96% <ø> (ø) ⬆️
babel.config.js 100% <100%> (ø) ⬆️
packages/core/src/jsx.js 100% <100%> (ø) ⬆️
packages/serialize/src/index.js 100% <100%> (ø) ⬆️
...ges/babel-plugin-emotion/src/utils/minify-utils.js 97.14% <100%> (+0.47%) ⬆️
packages/babel-plugin-emotion/src/utils/label.js 97.87% <100%> (+0.09%) ⬆️
packages/core/src/global.js 97.67% <100%> (+0.11%) ⬆️
... and 2 more

@Andarist Andarist closed this Jun 15, 2020
@Andarist
Copy link
Member

Damn, sorry for destroying this PR - I've merged our next to it and pushed it out as I've wanted to proceed with this, but something went wrong and now I can't even undo what I've done because I get permission denied error :/

@Andarist
Copy link
Member

I've pushed out your cherry-picked (and slightly adjusted) work and prepared a new PR here: #1902

@Andarist Andarist mentioned this pull request Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabels @Andarist