Skip to content

glow painter every where #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

glow painter every where #852

wants to merge 35 commits into from

Conversation

KentaTheBugMaker
Copy link
Contributor

@KentaTheBugMaker KentaTheBugMaker commented Oct 29, 2021 •
edited
Loading

egui_web webgl1 and webgl2 use almost same code .
egui_glow painter use very similar code to web painters.
so i port PostProcess to egui_glow.
and create new crate that only contains painter and context create utility.
Current status

  • OpenGL 2.1 or above(same as glow and glium)
  • WebGL2(same as egui_web)
  • WebGL1(same as egui_web)
  • WebGL1 + sRGB(same as egui_web)

t18b219k and others added 23 commits October 20, 2021 13:08
init egui_glow_painter by copy egui_glow painter
6c131a1
add context create function for web
92746f8 
replace assert macro to debug print for web debug
delete egui_glow painter and use egui_glow_painter
e4a022f
install glow painter to web (crash)
48dde27
correctly init webgl context
124e9cd
eliminate crash but black screen on webgl1
bc2678f
webgl1 progress but srgb support yet.
6f3ccb6
@KentaTheBugMaker
interim commit for tracking upstream
d7af224
@KentaTheBugMaker
merge upstream
8e992d5
@KentaTheBugMaker
fix broken when merge upstream
f1d6113
@KentaTheBugMaker
Merge branch 'emilk:master' into master
ea5c2a5
@KentaTheBugMaker
port post process from web
6f33e86
@KentaTheBugMaker
share WebGL2 and OpenGL shader
f130bdf
@KentaTheBugMaker
fix WebGL1 with sRGB support.
43631e7 
but black screen.
@KentaTheBugMaker
rollback eframe modding
ac9c263
@KentaTheBugMaker
pass sRGB support status from painter using #define SRGB_SUPPORTED
1417755
@KentaTheBugMaker
webGL1 with sRGB works well
8cf5a41
@KentaTheBugMaker
fmt
8f33833
@KentaTheBugMaker
tomlfmt
cc2f325
@KentaTheBugMaker
fmt
5bda67a
@KentaTheBugMaker
small refactoring
dacab37
@KentaTheBugMaker
don't squash shader compile and link errors
089ea47
@KentaTheBugMaker
some clippy fix
d2c7e76
@AlexApps99 AlexApps99 mentioned this pull request Oct 29, 2021
Closed
@KentaTheBugMaker
Copy link
Contributor Author

eliminated VAO by emulating VAO in painter.

@KentaTheBugMaker KentaTheBugMaker marked this pull request as ready for review October 30, 2021 06:50
@emilk
Copy link
Owner

emilk commented Nov 1, 2021

What is the motivation for adding egui_glow_painter as a separate crate? If you don't want the winit-stuff of egui_glow, perhaps we can hide that behind a feature-flag instead so we don't get too many crates?

@KentaTheBugMaker
Copy link
Contributor Author

OK I will make more acceptable new PR.

@KentaTheBugMaker KentaTheBugMaker mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KentaTheBugMaker @emilk