fix misroute when dealing multiple webservice with regex #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need this one to be merged, so I can safely upgrade some legacy codebase to v3. I did notice there is v4 branch, and I tested with v4 branch, this change are still compatible, and passing all unittest. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v3 #549 +/- ##
==========================================
+ Coverage 69.52% 69.72% +0.19%
==========================================
Files 28 28
Lines 1608 1625 +17
==========================================
+ Hits 1118 1133 +15
- Misses 415 417 +2
Partials 75 75 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feel pretty confident on this change: we skip regex tokens when detectWebService, but we still do regex match for each token on detectRoutes.
so there is no down side by doing extra regex match on detectWebService, and increase the score.
#548