Skip to content

Conversation

Samoed
Copy link
Member

@Samoed Samoed commented Aug 20, 2025

Close #3056
If you add a model or a dataset, please add the corresponding checklist:

@Samoed Samoed changed the title try to fix CI ci: try to fix CI Aug 20, 2025
@Samoed Samoed mentioned this pull request Aug 20, 2025
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Their fix is legitimate though, but they do break the contract of returning a similarly sized array in:

        evaluator = pytrec_eval.RelevanceEvaluator(
            qrels, {map_string, ndcg_string, recall_string, precision_string}
        )
        scores = evaluator.evaluate(results)

as:

len(qrels)
78
len(scores)
77

@KennethEnevoldsen KennethEnevoldsen changed the title ci: try to fix CI ci: Temporarily limit pytrec version to "pytrec-eval-terrier>=0.5.6, <0.5.8" to prevent errors Aug 20, 2025
@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) August 20, 2025 12:49
@KennethEnevoldsen KennethEnevoldsen merged commit 6fa6efa into main Aug 20, 2025
9 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the Samoed-patch-1 branch August 20, 2025 13:03
@KennethEnevoldsen
Copy link
Contributor

see also #3058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI currently fails
2 participants