fix: Updated revision for jina-embeddings-v4 #3046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: admin <bo.wang@jina.ai>
|
Can you open an issue in transformers to fix this? |
|
The issue was in the v4 model code, which has been fixed, but because the loader specifies an older revision, it still fails with MTEB |
|
But you can bump revision instead of removing it |
Signed-off-by: admin <bo.wang@jina.ai>
Ok
Verified |
KennethEnevoldsen
approved these changes
Aug 18, 2025
c58b319
into
embeddings-benchmark:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should remove the hardcoded revision from the jina-embeddings-v4 loader, as the specified version is incompatible with the latest Transformers release and causes evaluation to fail