Skip to content

model: Add granite-vision-embedding model #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 16, 2025

Conversation

roipony
Copy link
Contributor

@roipony roipony commented Aug 14, 2025

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.
  • The model is public, i.e. is available either as an API or the wieght are publicly avaiable to download

reference="https://huggingface.co/ibm-granite/granite-vision-3.3-2b-embedding",
similarity_fn_name="max_sim",
use_instructions=True,
training_datasets={},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add training datasets from their paper https://arxiv.org/abs/2502.09927?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, our training data is proprietary and not publicly accessible

@Samoed Samoed requested a review from isaac-chung August 14, 2025 12:10
@Samoed Samoed changed the title Add granite-vision-embedding model model: Add granite-vision-embedding model Aug 14, 2025
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a comment to add (added it myself) - I have enabled auto-merge and will take a look at the results

@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) August 16, 2025 13:03
auto-merge was automatically disabled August 16, 2025 18:32

Head branch was pushed to by a user without write access

@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) August 16, 2025 18:37
@KennethEnevoldsen KennethEnevoldsen merged commit 37d115a into embeddings-benchmark:main Aug 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants