Skip to content

model: Add samilpwc_models meta #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2025
Merged

model: Add samilpwc_models meta #3028

merged 4 commits into from
Aug 16, 2025

Conversation

ElPlaguister
Copy link
Contributor

Hi, We're about to add a Korean text embedding model.

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.
  • The model is public, i.e. is available either as an API or the wieght are publicly avaiable to download

@ElPlaguister ElPlaguister mentioned this pull request Aug 14, 2025
Merged
6 tasks
Samoed
Samoed reviewed Aug 14, 2025
View reviewed changes
KennethEnevoldsen

This comment was marked as duplicate.

Sign in to view

KennethEnevoldsen
KennethEnevoldsen requested changes Aug 16, 2025
View reviewed changes
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see some monolingual adaptation of the e5! Looks like the model is missing a model card. Can you please add this? (required)

Otherwise, the code and metadata look good

@ElPlaguister
Copy link
Contributor Author

Thank you for the feedback! The model card has been added to Hugging Face as requested.

Great to see some monolingual adaptation of the e5! Looks like the model is missing a model card. Can you please add this? (required)

Otherwise, the code and metadata look good

@KennethEnevoldsen KennethEnevoldsen merged commit 96a7cc5 into embeddings-benchmark:main Aug 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samoed Samoed Samoed left review comments

@KennethEnevoldsen KennethEnevoldsen KennethEnevoldsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElPlaguister @KennethEnevoldsen @Samoed