[v2] mteb.evaluate now saves model_meta.json
#2960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to save model metadata to a model_meta.json file when using mteb.evaluate. The change allows the evaluation process to preserve model metadata alongside task results for better tracking and reproducibility.
- Implements saving of
model_meta.jsonfile in the cache directory when model metadata is available - Updates the cache save method to accept and process model metadata
- Adds test coverage to verify the model metadata file is created during evaluation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| mteb/cache.py | Adds logic to save model metadata to model_meta.json file in the cache directory |
| tests/test_evaluation/test_evaluate.py | Adds test assertion to verify model metadata file creation |
isaac-chung
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2847