Skip to content

fix: Only import SparseEncoder once sentence-transformer version have been checked #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

fix: Only import SparseEncoder once sentence-transformer version have been checked #2940

merged 2 commits into from
Jul 22, 2025

Conversation

KennethEnevoldsen
Copy link
Contributor

fixes #2936

isaac-chung
isaac-chung reviewed Jul 22, 2025
View reviewed changes
@KennethEnevoldsen @isaac-chung
Update mteb/models/opensearch_neural_sparse_models.py
f2f9f08 
Co-authored-by: Isaac Chung <chungisaac1217@gmail.com>
@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) July 22, 2025 12:47
@KennethEnevoldsen KennethEnevoldsen merged commit 79a43af into main Jul 22, 2025
10 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the fix-import-for-sparse-encoders branch July 22, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-chung isaac-chung isaac-chung left review comments

@Samoed Samoed Awaiting requested review from Samoed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newly added SparseEncoder required sentence-transformers>=5.0.0
2 participants
@KennethEnevoldsen @isaac-chung