dataset: Add BSARD v2, fixing the data loading issues of v1 #2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the fix! This generally looks pretty good. We will need to add superseeded by and update the description, but otherwise I think we can merge.
Is it possible for you to compare a few models on the two tasks, just to see what the practical implications are?
ndcg, mrr, map are higher. |
KennethEnevoldsen
approved these changes
Jul 25, 2025
|
Looks great! I have changes the description slightly and enables auto-merge (if all tests pass it will merge automatically) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes 2906 by adding the second version of BSARD with the proper loader.