fix: change passage prompt to document
#2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please get the tests passing? |
|
There's no change to pyproject.toml yet. Would allowing ST v5 pass all the tests? |
|
I don't think we need to change anything in pyproject, because tests is run with sentence transformers |
isaac-chung
approved these changes
Jul 20, 2025
|
isn't this a breaking change for anyone implementing their own models? |
|
I think probably yes |
|
Hmm, probably shouldn't have been merged as a fix then (feat at least if not included in v2) Well don't think we should change it now, but worth keeping in mind in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
passageprompt name todocumentin all places to make compatible withSentenceTransformersv5.Closes #2896