[v2] Refactor CoPali new interface #2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-chung
commented
Jun 23, 2025
isaac-chung
commented
Jun 23, 2025
| @@ -38,15 +41,42 @@ def __init__( | |||
|
|
|||
| # Load model | |||
| self.mdl = model_class.from_pretrained( | |||
| model_name, revision=revision, device_map=self.device, **kwargs | |||
| model_name, device_map=self.device, **kwargs | |||
There was a problem hiding this comment.
With revision there, I kept running into this error, which disappeared when I removed revision:
File "/opt/homebrew/anaconda3/envs/mteb/lib/python3.11/site-packages/transformers/modeling_utils.py", line 1100, in _get_resolved_checkpoint_files raise EnvironmentError( OSError: vidore/colpaligemma-3b-mix-448-base does not appear to have a file named pytorch_model.bin, model.safetensors, tf_model.h5, model.ckpt or flax_model.msgpack.
There was a problem hiding this comment.
I don't think that we want to remove revision here. Which model did you use?
There was a problem hiding this comment.
I tested all 3. Could you see if you can run any of these successfully with revision?
mteb run -m vidore/colpali-v1.2 -t MNIST
Samoed
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2771
If you add a model or a dataset, please add the corresponding checklist: