fix: rename TaskMetadata.py to resolve class/module ambiguity #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors imports following this pattern: ```py # tasks/__init__ from .Retrieval import * # tasks/retrieval/__init__ from .eng import * # tasks/retrieval/eng/__init__ from .task1 import Task1 ``` proposed by @Samoed in #2825. This should reduce the number of imports required, while not exposing any of the module requires at the task definition.
Samoed
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #1124
required for: #2714
Seems like we in multiple places denote the module instead of the intended TaskMetada. This rename should fix that issue
relies on PR #2828