Skip to content

[mieb] Fill in mocov3 and nomic vision model meta #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2025
Merged

[mieb] Fill in mocov3 and nomic vision model meta #1890

merged 3 commits into from
Jan 28, 2025

Conversation

isaac-chung
Copy link
Collaborator

Fill in mocov3 and nomic vision model meta

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

isaac-chung
isaac-chung commented Jan 28, 2025
View reviewed changes
mteb/models/nomic_models_vision.py
similarity_fn_name=None,
use_instructions=None,
use_instructions=True,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does using a prefix like search query: mean use_instructions=True?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now yes, but I don't like. I'll create issue for discussion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1891 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, wrong copy paste

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@isaac-chung isaac-chung mentioned this pull request Jan 28, 2025
Closed
@isaac-chung isaac-chung merged commit a783b04 into mieb Jan 28, 2025
11 checks passed
@isaac-chung isaac-chung deleted the fill-in-moco-and-nomic-vision-model-meta branch January 28, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samoed Samoed Samoed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaac-chung @Samoed