Skip to content

[mieb] Fill in cohere_v and dinov2 model meta #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

[mieb] Fill in cohere_v and dinov2 model meta #1880

merged 1 commit into from
Jan 27, 2025

Conversation

isaac-chung
Copy link
Collaborator

Fill in cohere_v and dinov2 model meta

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

@isaac-chung isaac-chung mentioned this pull request Jan 27, 2025
Closed
@isaac-chung isaac-chung requested a review from Samoed January 27, 2025 08:31
@isaac-chung isaac-chung merged commit d113086 into mieb Jan 27, 2025
11 checks passed
@isaac-chung isaac-chung deleted the fill-in-cohere-v-dino-model-meta branch January 27, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samoed Samoed Samoed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaac-chung @Samoed