Skip to content

Conversation

imenelydiaker
Copy link
Contributor

@imenelydiaker imenelydiaker commented Nov 20, 2024

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

I ran some of the missing tasks, and @dokato is running the rest. Also added in this PR the number of qrels (num_relevant_docs) for retrieval datasets (updated 2 tasks for testing).

@imenelydiaker imenelydiaker requested a review from Samoed November 20, 2024 12:17
Copy link
Member

@Samoed Samoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@imenelydiaker
Copy link
Contributor Author

@Samoed can you check the tests? I'm not sure why they're not passing 🤔

@Samoed
Copy link
Member

Samoed commented Nov 21, 2024

I'll fix them in 2h

@Samoed
Copy link
Member

Samoed commented Nov 21, 2024

It seems that it tried to merge this branch with 2.0.0 and applied the test from there. In the 2.0.0 branch, I updated the test to check whether a task has metadata or not.

@Samoed
Copy link
Member

Samoed commented Nov 21, 2024

I think this can be merged now @imenelydiaker

@imenelydiaker
Copy link
Contributor Author

Thanks @Samoed, merging!

@imenelydiaker imenelydiaker merged commit 0abe1a0 into v2.0.0 Nov 21, 2024
10 checks passed
@imenelydiaker imenelydiaker deleted the 1475-add-descriptive_stats-to-all-tasks branch November 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants