Skip to content

fix: remove NaN handling #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: remove NaN handling #1444

wants to merge 1 commit into from

Conversation

KennethEnevoldsen
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen commented Nov 13, 2024 •
edited by isaac-chung
Loading

As discussed in #1398 NaN should never occur. Removing handling of them.

Fixes #1389

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

@KennethEnevoldsen
fix: remove NaN handling
a92963a 
As discussed in #1398 NaN should never occur. Removing handling of them.

Fixes #1389
@KennethEnevoldsen KennethEnevoldsen requested review from isaac-chung and orionw and removed request for isaac-chung November 13, 2024 12:57
@KennethEnevoldsen KennethEnevoldsen mentioned this pull request Nov 13, 2024
Merged
2 tasks
@KennethEnevoldsen
Copy link
Contributor Author

KennethEnevoldsen commented Nov 14, 2024 •
edited
Loading

@orionw not quite sure about the merge conflict here - seems like there is no conflict, but I might be missing something ? (code might have been deleted and moved elsewhere)

@Samoed
Copy link
Member

Samoed commented Nov 14, 2024 •
edited
Loading

Code was moved to

mteb/mteb/evaluation/evaluators/model_classes.py

Lines 341 to 351 in 9c58518

with torch.inference_mode():
cos_scores = self.score_functions[score_function](
query_embeddings, sub_corpus_embeddings
)
is_nan = torch.isnan(cos_scores)
if is_nan.sum() > 0:
raise ValueError(
f"NaN values detected in the similarity scores: {is_nan.sum()}"
)

@KennethEnevoldsen
Copy link
Contributor Author

Perfect - redid the fix directly on v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-chung isaac-chung isaac-chung approved these changes

@orionw orionw Awaiting requested review from orionw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KennethEnevoldsen @Samoed @isaac-chung