Skip to content

Conversation

KennethEnevoldsen
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen commented Apr 18, 2024

(adds missing points)

  • add the longembed benchmark

  • add longembed bench & make lint

  • add meta data and model scores

  • add all metadata and passkey&needle scores

  • remove prints

  • replace context length with test_256, test_512, ...

dwzhu-pku and others added 3 commits April 18, 2024 12:51
* add the longembed benchmark

* add longembed bench & make lint

* add meta data and model scores

* add all metadata and passkey&needle scores

* remove prints

* replace context length with test_256, test_512, ...
for reviews and 2*6 for datasets
@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) April 18, 2024 10:54
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwzhu-pku and @isaac-chung added points here for #393

Copy link
Collaborator

@isaac-chung isaac-chung Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Btw are PR reviews 1 point or 2 points? I've been doing 1 but I just realized that docs/mmteb/readme.md mentions 2 points 🤔 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, me too (damn!) - I realized this yesterday - feel free to do a PR duplicating the review scores

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it here: #435

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did mine via #425 so will remove the changes to mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants