Skip to content

Id clickbait #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2024
Merged

Id clickbait #411

merged 4 commits into from
Apr 18, 2024

Conversation

manandey
Copy link
Contributor

  • I have tested that the dataset runs with the mteb package.
  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb run -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • I have considered the size of the dataset and reduced it if it is too big (2048 examples is typically large enough for most tasks)
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.
  • I have added points for my submission to the POINTS.md file.

@manandey
Copy link
Contributor Author

@KennethEnevoldsen Can you do a review if possible?

isaac-chung
isaac-chung reviewed Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@isaac-chung isaac-chung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. I've added a small suggestion. Everything else looks good.

Please add +1 point for me for the review as well.

@KennethEnevoldsen KennethEnevoldsen merged commit a0fa60b into embeddings-benchmark:main Apr 18, 2024
@isaac-chung isaac-chung mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-chung isaac-chung isaac-chung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manandey @isaac-chung @KennethEnevoldsen