Skip to content

Add icon param in the Benchmark class #2555

@isaac-chung

Description

@isaac-chung

If we add an icon param for the benchmark (default None), and use the display_on_leaderboard param in the Benchmark class, we can programmatically create BENCHMARK_ENTRIES. That way, we won't have 2 definitions of the same objects. Easier to maintain.

I feel that regardless of the connection to the UI, keeping definitions unique is important for maintenance. We can totally do it in a separate PR tho.

Originally posted by @isaac-chung in #2549 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    leaderboardissues related to the leaderboard

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions