Skip to content

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Nov 29, 2022

Python 3.11 was released on 10/24: https://blog.python.org/2022/10/python-3110-is-now-available.html

Signed-off-by: Patrick Titzler ptitzler@us.ibm.com
Signed-off-by: Kevin Bates kbates4@gmail.com

What changes were proposed in this pull request?

  • Add Python 3.11 CI tests
  • Update code/artifacts to tolerate Python 3.11

How was this pull request tested?

  • CI

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added component:test Test-related kind:CI Impacts continuous integration (build, test, etc.) sizing: XS labels Nov 29, 2022
@elyra-bot
Copy link

elyra-bot bot commented Nov 29, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@kevin-bates
Copy link
Member

I think we need to specify -c conda-forge when building the image:

elyra/Makefile

Line 209 in 0885484

elyra-image-env: ## Creates a conda env consisting of the dependencies used in images

I just tried creating the python 3.11 env and it appears that's the place it finds 3.11. (I alias conda to mamba and I believe conda-forge is "built into" mamba.

We should also update the set of classifiers.

ptitzler and others added 4 commits November 29, 2022 07:34
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
@akchinSTC akchinSTC self-requested a review November 29, 2022 22:35
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
@ptitzler ptitzler changed the title Add Python 3.11 to server test matrix Add Python 3.11 support Nov 30, 2022
@ptitzler ptitzler added this to the 3.14.0 milestone Nov 30, 2022
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC merged commit 38dee78 into elyra-ai:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:test Test-related kind:CI Impacts continuous integration (build, test, etc.) sizing: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants