Skip to content

Update package to include all-optional-dependencies subpackage #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Update package to include all-optional-dependencies subpackage #3067

merged 1 commit into from
Jan 12, 2023

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Jan 6, 2023 •
edited
Loading

Reintroduces the [all] subpackage for installing all optional dependencies.

Signed-off-by: Alan Chin akchin@us.ibm.com

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC akchinSTC added the area:documentation Improvements or additions to documentation label Jan 6, 2023
@akchinSTC akchinSTC added this to the 3.14.2 milestone Jan 6, 2023
@akchinSTC akchinSTC requested a review from kevin-bates January 9, 2023 18:57
@kevin-bates
Copy link
Member

Would it be less disruptive to just add support for all and ensure it's manually updated whenever new non-test optional dependencies are added?

kfp-tekton = [
    "kfp-tekton~=1.3.0"
]
kfp-examples = [
    "elyra-examples-kfp-catalog"
]
gitlab = [
    "python-gitlab"
]
# The following is a collection of "non-test" extra dependencies from above.
all = [
    "kfp-tekton~=1.3.0",
    "elyra-examples-kfp-catalog",
    "python-gitlab",
]

Running pip install "dist/elyra-3.15.0.dev0-py3-none-any.whl[all]" seems to add the appropriate extras with this change.

@akchinSTC
Copy link
Member Author

Would it be less disruptive to just add support for all and ensure it's manually updated whenever new non-test optional dependencies are added?

I could go either way. If there are no objections in the next day or two from anyone, Ill update the PR and rename it to reflect the existing way of installation

@akchinSTC
Update package to include all-optional-dependencies subpackage
557a86b 
Signed-off-by: Alan Chin <akchin@us.ibm.com>
@akchinSTC akchinSTC changed the title Update subpackage installation references in documentation Update package to include all-optional-dependencies subpackage Jan 11, 2023
kevin-bates
kevin-bates approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 - thanks @akchinSTC!

@kevin-bates kevin-bates added component:build build and build related issues(dependencies and docker) dependencies Pull requests that update a dependency file and removed area:documentation Improvements or additions to documentation labels Jan 12, 2023
@akchinSTC akchinSTC merged commit 42d86a2 into elyra-ai:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
component:build build and build related issues(dependencies and docker) dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@akchinSTC @kevin-bates