Skip to content

Conversation

FreeWillyB
Copy link
Contributor

If the user doesn't set the search engine and their request fails, I set the search engine to be "google" and recall the "getLyrics" method and store the output in a local variable. After that method runs, the search engine is set back to default and the output from that method that was stored in the local variable is return to the original caller.

This is an update from the previous commit from my "retries" branch that resolves some conflicts with original PR.

@elmoiv
Copy link
Owner

elmoiv commented Feb 2, 2022

There are still conflicts. Fix them first and then I will review your PR.

Thanks for your contribution and sorry for replying too late.

@FreeWillyB
Copy link
Contributor Author

I had to delete your manual "404" return. To recap my changes, whenever the "getLyrics" or "getSongs" is called and the status code is not "200", then my code looks to see if the user specified a search engine.
-> If they did not, then it sets the search engine to Google and recurses, and resets itself back to self.search_engine='' after it returns. If
-> If the user DID specific a search engine (which also covers the case above where the function automatically recurses), then it returns the ACTUAL status code of the request instead of the hard-coded 404 error. This gives more accurate information for the cause of the issue whenever a look up fails.

@elmoiv elmoiv merged commit f7fd583 into elmoiv:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants