I'm also looking into writing a test for this use case. Currently I have this:

func (s *LocalPGPTest) TestGnupgHomeOverride() {
    os.Setenv("GNUPGHOME", "/foo")
    _, err := NewLocalPGPService()
    s.True(err.Error() == "stat /foo/.gnupg/pubring.gpg: no such file or directory")
    os.Unsetenv("GNUPGHOME")
}

Which I find a bit ugly, since this asserts on matching an error string, instead of the compiled path.
The problem is that without mocking (or being able to mock?) os.Stat, there is no other way around this as I see it.
I haven't had too much experience with go, so any insight in a proper solution is very welcome.

Great idea to use $GNUPGHOME. I'll be able to dig into this over the weekend and get you more feedback. Thanks!

For the test, it might make sense to extract the ringfile composition out to a method that returns the full path, and then test the method instead of the whole constructor. That way you don't have to worry about testing whether the file exists with os.Stat. (Which is really pushing off the inevitable, but at least then it's my problem, not yours!)

Hi @ellotheth

I just refactored the ringfile to a separate struct and added/changed tests for multiple use cases.
As for pushing off the os.Stat mocking, I agree that splitting for now is a good solution.

dennisdegreef#1

Let me know what you think, when I merge this, it'll be added in this branch/PR.

Hi @dennisdegreef,

Your branch looks stellar, but I'm not quite ready to start wrapping os methods to that extent. I had in mind something simpler, like e9995dc...alt-for-gnupghome. It skips dealing with os.Stat entirely, and focuses on building the file path. What do you think?

It looks good! 👍 I was just trying out a different solution, while making myself more familiar with Golang.
Your solution is indeed simpler. I'll cherry-pick that commit in my branch. Thanks.

Now that I've dirtied up master, do you mind rebasing your branch? I'll merge and tag everything afterwards.

No problem, pushed it