Support for ChromeDriver arguments #191
Conversation
lib/application.js
Outdated
| @@ -144,6 +146,10 @@ Application.prototype.createClient = function () { | |||
| args.push('spectron-env-' + name + '=' + self.env[name]) | |||
| } | |||
|
|
|||
| for (var index in self.chromeDriverArgs) { | |||
There was a problem hiding this comment.
Might be a little cleaner written in the style of line 141:
self.chromeDriverArgs.forEach(function (arg) {
args.push(arg)
})
README.md
Outdated
| See [here](https://sites.google.com/a/chromium.org/chromedriver/capabilities) | ||
| for details on the Chrome arguments. | ||
| * `args` - Array of arguments to pass to the Electron application. | ||
| * `chromeDriverArgs` - Array of arguments to pass to the ChromeDriver. |
There was a problem hiding this comment.
I think this can be just to ChromeDriver instead of to the ChromeDriver.
|
@kevinsawicki thanks, I forgot to add typings initially -> added them in 694288e now. |
|
@michelkaporin thanks for this, great work 👍 I've published this in 3.7.1. The 3.7.x line supports Electron 1.7.x, so if you need this in Electron 1.6.x, let me know and we can merge this into that release line and cut a new 3.6.x spectron release. |
|
@kevinsawicki it would be great if you can cut a new 3.6.x spectron release please, as we are on Electron 1.6.6 currently. |
Sure thing, published as 3.6.4 via #195 |
|
Perfect, thank you @kevinsawicki! |
Added capability of providing ChromeDriver arguments. This resolves #189.