Convert to use the electron-installer-common ElectronInstaller class #104
Conversation
| data.logger(`Successfully created package at ${options.dest}`) | ||
| return options | ||
| data.logger(`Successfully created package at ${installer.options.dest}`) | ||
| return installer.options | ||
| }).catch(err => { | ||
| data.logger(common.errorMessage('creating package', err)) | ||
| throw err | ||
| }) | ||
|
|
||
| return nodeify(promise, callback) |
There was a problem hiding this comment.
We need to remove callback support. It's too bad that only now I realize about this, which could have been part of a previous release
There was a problem hiding this comment.
I think it's also in -windows.
There was a problem hiding this comment.
I also have nodeify in electron-installer-snap. I was planning on getting rid of that dependency the next time there's a major version bump, for -snap hopefully that's when Node 6 is EOL'd.
There was a problem hiding this comment.
That's a great idea, wait for Node 6 EOL and then remove nodeify from all modules that still use it.
|
@fcastilloec FYI, I've made the requested changes. I'm probably just going to merge later today (here and in the other PRs) since you probably don't have time to look at the updates. |
Utilizes
electron-installer-common0.6.0.