Skip to content

Conversation

fcastilloec
Copy link
Collaborator

This fixes #78

@fcastilloec fcastilloec requested a review from malept December 11, 2018 05:34
@@ -113,4 +114,30 @@ describe('module', function () {

it('generates a `.rpm` package', () => assertNonASARRpmExists(outputDir))
})

describeInstaller(
'with an app with installation scripts as paths',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies that you can specify installation scripts as not-paths (inline?) somehow...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. Inline is not the preferred way, as scripts can be lengthy, that's why I did not document this option. Currently, users need to pass a scripts object with the paths, but they can also pass options.pre, options.post, etc. containing the script's body as a string and that would also work. This is a side effect on how templates work with lodash. We need to send the options object to the template to generate the specs file and that object has to contain the contents of the scripts already, so people could just add the contents of the scripts directly to the options object

@fcastilloec fcastilloec merged commit 43812e8 into master Dec 12, 2018
@fcastilloec fcastilloec deleted the installation-scripts branch December 12, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for pre, post, preun, postun scripts
2 participants