-
Notifications
You must be signed in to change notification settings - Fork 47
Installation scripts #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is temporary, we should already have removed support for this version of node
@@ -113,4 +114,30 @@ describe('module', function () { | |||
|
|||
it('generates a `.rpm` package', () => assertNonASARRpmExists(outputDir)) | |||
}) | |||
|
|||
describeInstaller( | |||
'with an app with installation scripts as paths', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implies that you can specify installation scripts as not-paths (inline?) somehow...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does. Inline is not the preferred way, as scripts can be lengthy, that's why I did not document this option. Currently, users need to pass a scripts
object with the paths, but they can also pass options.pre
, options.post
, etc. containing the script's body as a string and that would also work. This is a side effect on how templates work with lodash. We need to send the options
object to the template to generate the specs file and that object has to contain the contents of the scripts already, so people could just add the contents of the scripts directly to the options
object
750adf1
to
723f6c4
Compare
This fixes #78