feat(deployment): expand macros in S3 options #1349
Conversation
|
@piotrdubiel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Anmo and @arekkas to be potential reviewers. |
|
Resolving in this place is ok, because in any case result is not cached — to be able to specify publish config per target. Anyway, arch is not used currently. |
| } | ||
|
|
||
| function expandPublishConfig(packager: PlatformPackager<any>, publishConfig: PublishConfiguration) { | ||
| if ((<S3Options>publishConfig).bucket != null) { |
There was a problem hiding this comment.
I think we can just expand macro for all keys in the object. It also will allow us to remove explicit expand for generic URL (see usages in this file). Could you please do it?
There was a problem hiding this comment.
Done. One question: is it ok not to add arch in computeDownloadUrl to expand?
There was a problem hiding this comment.
Too soon, need to fix, because for some reason tests are failing.
There was a problem hiding this comment.
Only snap test should be failed (unrelated).
There was a problem hiding this comment.
I think it's fixed.
becec9c to
72886fc
Compare
S3 options can now contain macros to allow something like this:
```
"publish": {
"provider": "s3",
"bucket": "some-bucket",
"path": "${os}/${env.SOME_ENV}"
}
```
Now `bucket`, `path` and `channel` can contain macros. Previously these options couldn't be configured with macros.
72886fc to
b36e6a3
Compare
S3 options can now contain macros to allow something like this:
Now
bucket,pathandchannelcan contain macros. Previously these options couldn't be configured with macros.