unlisted deps are not pruned automatically if two-package.json structure not used #770
Description
- Version: 7.3.0
- Target: macOS
Code signing failing only when asar option is set to true. When set as false code signing works fine and dmg and zip files are created.
Node version - v6.2.2
npm version - 3.9.5
My System - OS X El Capitan 10.11.4
Logs:
electron-osx-sign Signing... /opt/eltropy/cello/dist/mac/Eltropy Sync.app/Contents/Resources/app.asar.unpacked/app/node_modules/electron-prebuilt/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib +2s
electron-osx-sign Signing... /opt/eltropy/cello/dist/mac/Eltropy Sync.app/Contents/Resources/app.asar.unpacked/app/node_modules/electron-prebuilt/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib +434ms
electron-osx-sign Signing... /opt/eltropy/cello/dist/mac/Eltropy Sync.app/Contents/Resources/app.asar.unpacked/app/node_modules/electron-prebuilt/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/crashpad_handler +667ms
electron-osx-sign Signing... /opt/eltropy/cello/dist/mac/Eltropy Sync.app/Contents/Resources/app.asar.unpacked/app/node_modules/electron-prebuilt/dist/Electron.app/Contents/Frameworks/Electron Framework.framework +401ms
Error: Command failed: codesign --sign Developer ID Application: Eltropy Inc (L7YA27678X) --force /opt/eltropy/cello/dist/mac/Eltropy Sync.app/Contents/Resources/app.asar.unpacked/app/node_modules/electron-prebuilt/dist/Electron.app/Contents/Frameworks/Electron Framework.framework
/opt/eltropy/cello/dist/mac/Eltropy Sync.app/Contents/Resources/app.asar.unpacked/app/node_modules/electron-prebuilt/dist/Electron.app/Contents/Frameworks/Electron Framework.framework: bundle format unrecognized, invalid, or unsuitable
at ChildProcess.exithandler (child_process.js:207:12)
From previous event:
at /opt/eltropy/cello/node_modules/electron-osx-sign-tf/index.js:443:18
at ChildProcess.exithandler (child_process.js:198:7)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:852:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
From previous event:
at /opt/eltropy/cello/node_modules/electron-osx-sign-tf/index.js:437:27
From previous event:
at signApplicationAsync (/opt/eltropy/cello/node_modules/electron-osx-sign-tf/index.js:395:6)
at /opt/eltropy/cello/node_modules/electron-osx-sign-tf/index.js:564:14
From previous event:
at Function.signAsync (/opt/eltropy/cello/node_modules/electron-osx-sign-tf/index.js:556:6)
at MacPackager.<anonymous> (/opt/eltropy/cello/node_modules/electron-builder/src/macPackager.ts:183:21)
at next (native)
From previous event:
at tsAwaiter (/opt/eltropy/cello/node_modules/electron-builder/src/util/awaiter.ts:10:47)
at MacPackager.sign (/opt/eltropy/cello/node_modules/electron-builder/src/macPackager.ts:98:75)
at nonMasPromise.doPack.then (/opt/eltropy/cello/node_modules/electron-builder/src/macPackager.ts:78:26)
From previous event:
at MacPackager.<anonymous> (/opt/eltropy/cello/node_modules/electron-builder/src/macPackager.ts:78:10)
at next (native)
From previous event:
at tsAwaiter (/opt/eltropy/cello/node_modules/electron-builder/src/util/awaiter.ts:10:47)
at Object.build (/opt/eltropy/cello/node_modules/electron-builder/src/builder.ts:181:52)
at Object.<anonymous> (/opt/eltropy/cello/node_modules/electron-builder/src/build-cli.ts:27:28)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:458:32)
at tryModuleLoad (module.js:417:12)
at Function.Module._load (module.js:409:3)
at Module.runMain (module.js:575:10)
at run (node.js:348:7)
at startup (node.js:140:9)
at node.js:463:3
My build package.json:
{
"devDependencies": {
"electron-builder": "7.3.0",
"electron": "1.4.0"
},
"build": {
"asar": true,
"appId": "com.eltropy.syncapp",
"productName": "Eltropy Sync",
"category": "public.app-category.business",
"win": {
"iconUrl": "https://s3-us-west-2.amazonaws.com/sync-app/assets/ico.ico",
"loadingGif": "build/installer.gif",
"icon": "build/ico_256.ico",
"setupIcon": "build/ico.ico"
},
"dmg": {
"title": "EltropySync",
"icon": "build/icon.icns",
"background": "build/mac_install.png",
"contents": [
{
"x": 450,
"y": 320,
"type": "link",
"path": "/Applications"
},
{
"x": 180,
"y": 320,
"type": "file"
}
]
}
},
"scripts": {
"postinstall": "install-app-deps",
"start": "electron ./app",
"dist": "build -w --ia32",
"distm": "build -m"
}
}
To test further I cloned a sample electron app repo -
https://github.com/develar/onshape-desktop-shell
This initially had "asar": false which I changed to true. And then I tried building the app. Everything worked fine including code signing and build.