Skip to content

NSIS: Extracting wrong archive #567

@TomSeldon

Description

@TomSeldon
  • Version: 5.10.5
  • Target: NSIS (ia32)

I seem to have found an issue whereby the NSIS installer is trying to extract the wrong archive. The affected code can be seen here:

  ${If} ${RunningX64}
    Nsis7z::Extract "$PLUGINSDIR\app-64.7z"
  ${Else}
    Nsis7z::Extract "$PLUGINSDIR\app-32.7z"
  ${EndIf}

The specific issue is when targeting only ia32, but then trying to run the resultant installer on a x64 machine. The above check assumes that if the current machine is x64 based, then the x64 installer will exist. In fact, only the ia32 version exists which it never tries to extract.

The result is that the installer runs "successfully", but actually just outputs nothing. It tries to extract a non-existent archive.

My understanding (which may well be wrong) is that the ia32 installer should run on x64 machines, and so by targeting just ia32 it will just work on both architectures.

I've worked around this for now by targeting both ia32 and x64, however I don't think this should be necessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions