Skip to content

Allow Build for Pull Requests / Code Sign Artifacts using an option #1524

@djalmaaraujo

Description

@djalmaaraujo
  • Version: 16.8.3
  • Target: macOS and Windows

After this issue: #1354 we are not allowing to code sign artifacts during a pull-request build. While I understand the security issue, I still think that would be useful to have an option like build_for_pull_requests (boolean).

In our current workflow, we build/codesign apps to make real tests during the development of big features. We can easily perform QA tests with that option.

Right now, I have a workaround to make this work, but it's hacky:

Setting all these 3 vars TRAVIS_PULL_REQUEST CI_PULL_REQUEST CI_PULL_REQUESTS to false on the CI would make the build run for pull requests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions