feat(mac): allow build for pull requests / code sign artifacts

develar · develar · commit 9dbc7895b08b · 2017-05-04T18:47:45.000+02:00
Close #1524
diff --git a/packages/electron-builder/src/macPackager.ts b/packages/electron-builder/src/macPackager.ts
@@ -115,8 +115,9 @@ export default class MacPackager extends PlatformPackager<MacOptions> {
       warn("macOS application code signing is supported only on macOS, skipping.")
       return
     }
-    if (isPullRequest()) {
-      log("Current build is a part of pull request, code signing will be skipped")
+    if (process.env.CSC_FOR_PULL_REQUEST !== "true" && isPullRequest()) {
+      // https://github.com/electron-userland/electron-builder/issues/1524
+      log("Current build is a part of pull request, code signing will be skipped. Set env CSC_FOR_PULL_REQUEST to true to force code signing.")
       return
     }
 

Original file line number	Diff line number	Diff line change
`@@ -115,8 +115,9 @@ export default class MacPackager extends PlatformPackager<MacOptions> {`
`115`	`115`	`warn("macOS application code signing is supported only on macOS, skipping.")`
`116`	`116`	`return`
`117`	`117`	`}`
`118`		`- if (isPullRequest()) {`
`119`		`- log("Current build is a part of pull request, code signing will be skipped")`
	`118`	`+ if (process.env.CSC_FOR_PULL_REQUEST !== "true" && isPullRequest()) {`
	`119`	`+ // https://github.com/electron-userland/electron-builder/issues/1524`
	`120`	`+ log("Current build is a part of pull request, code signing will be skipped. Set env CSC_FOR_PULL_REQUEST to true to force code signing.")`
`120`	`121`	`return`
`121`	`122`	`}`
`122`	`123`