feat(electron-updater): Port support for downloads, Protocol support for generic backend

Frugality · develar · commit 8d883f131bb9 · 2017-01-18T07:58:43.000+01:00
Use specified port when downloading file
  Pass protocol through, allowing http: for local testing. Default is still https:
diff --git a/packages/electron-auto-updater/src/GenericProvider.ts b/packages/electron-auto-updater/src/GenericProvider.ts
@@ -16,7 +16,7 @@ export class GenericProvider implements Provider<UpdateInfo> {
     const channelFile = getChannelFilename(this.channel)
     const pathname = path.posix.resolve(this.baseUrl.pathname || "/", `${channelFile}`)
     try {
-      result = await request<UpdateInfo>({hostname: this.baseUrl.hostname, port: this.baseUrl.port || "443", path: `${pathname}${this.baseUrl.search || ""}`})
+      result = await request<UpdateInfo>({hostname: this.baseUrl.hostname, port: this.baseUrl.port || "443", path: `${pathname}${this.baseUrl.search || ""}`, protocol: this.baseUrl.protocol})
     }
     catch (e) {
       if (e instanceof HttpError && e.response.statusCode === 404) {
diff --git a/packages/electron-auto-updater/src/electronHttpExecutor.ts b/packages/electron-auto-updater/src/electronHttpExecutor.ts
@@ -41,6 +41,7 @@ export class ElectronHttpExecutor extends HttpExecutor<Electron.RequestOptions,
       protocol: parsedUrl.protocol,
       hostname: parsedUrl.hostname,
       path: parsedUrl.path,
+      port: parsedUrl.port ? +parsedUrl.port : undefined,
       headers: {
         "User-Agent": "electron-builder"
       },
@@ -80,7 +81,7 @@ export class ElectronHttpExecutor extends HttpExecutor<Electron.RequestOptions,
       (<any>requestOptions.headers).authorization = token.startsWith("Basic") ? token : `token ${token}`
     }
 
-    requestOptions.protocol = "https:"
+    requestOptions.protocol = options.Protocol || "https:"
     return new BluebirdPromise<T>((resolve, reject, onCancel) => {
       const request = net.request(options, response => {
         try {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export class GenericProvider implements Provider<UpdateInfo> {`
`16`	`16`	`const channelFile = getChannelFilename(this.channel)`
`17`	`17`	const pathname = path.posix.resolve(this.baseUrl.pathname \|\| "/", `${channelFile}`)
`18`	`18`	`try {`
`19`		- result = await request<UpdateInfo>({hostname: this.baseUrl.hostname, port: this.baseUrl.port \|\| "443", path: `${pathname}${this.baseUrl.search \|\| ""}`})
	`19`	+ result = await request<UpdateInfo>({hostname: this.baseUrl.hostname, port: this.baseUrl.port \|\| "443", path: `${pathname}${this.baseUrl.search \|\| ""}`, protocol: this.baseUrl.protocol})
`20`	`20`	`}`
`21`	`21`	`catch (e) {`
`22`	`22`	`if (e instanceof HttpError && e.response.statusCode === 404) {`