fix: check that noMsi specified as bool

develar · develar · commit 8266b22f3bfd · 2016-04-16T20:17:55.000+02:00
Closes #316
diff --git a/package.json b/package.json
@@ -58,7 +58,7 @@
     "command-line-args": "^2.1.6",
     "electron-packager-tf": "^6.0.3-beta.3",
     "electron-winstaller-fixed": "^2.2.1-beta.0",
-    "fs-extra": "^0.26.7",
+    "fs-extra": "^0.27.0",
     "fs-extra-p": "^0.2.0",
     "globby": "^4.0.0",
     "hosted-git-info": "^2.1.4",
diff --git a/src/winPackager.ts b/src/winPackager.ts
@@ -227,4 +227,9 @@ function checkConflictingOptions(options: any) {
       throw new Error(`Option ${name} is ignored, do not specify it.`)
     }
   }
+
+  const noMsi = options.noMsi
+  if (noMsi != null && typeof noMsi !== "boolean") {
+    throw new Error(`noMsi expected to be boolean value, but string '"${noMsi}"' was specified`)
+  }
 }
diff --git a/test/src/winPackagerTest.ts b/test/src/winPackagerTest.ts
@@ -11,9 +11,7 @@ import * as assertThat from "should/as-function"
 //noinspection JSUnusedLocalSymbols
 const __awaiter = require("out/awaiter")
 
-test.ifNotTravis("win", () => assertPack("test-app-one", {
-    platform: [Platform.WINDOWS],
-  },
+test.ifNotTravis("win", () => assertPack("test-app-one", platform(Platform.WINDOWS),
   {
     tempDirCreated: process.env.TEST_DELTA ? it => modifyPackageJson(it, data => {
       data.build.win = {
@@ -23,6 +21,16 @@ test.ifNotTravis("win", () => assertPack("test-app-one", {
   }
 ))
 
+test.ifNotTravis("noMsi as string", t => t.throws(assertPack("test-app-one", platform(Platform.WINDOWS),
+  {
+    tempDirCreated: it => modifyPackageJson(it, data => {
+      data.build.win = {
+        noMsi: "false",
+      }
+    })
+  }), `noMsi expected to be boolean value, but string '"false"' was specified`)
+)
+
 test("detect install-spinner", () => {
   let platformPackager: CheckingWinPackager = null
   let loadingGifPath: string = null

Original file line number	Diff line number	Diff line change
`@@ -227,4 +227,9 @@ function checkConflictingOptions(options: any) {`
`227`	`227`	throw new Error(`Option ${name} is ignored, do not specify it.`)
`228`	`228`	`}`
`229`	`229`	`}`
	`230`	`+`
	`231`	`+ const noMsi = options.noMsi`
	`232`	`+ if (noMsi != null && typeof noMsi !== "boolean") {`
	`233`	+ throw new Error(`noMsi expected to be boolean value, but string '"${noMsi}"' was specified`)
	`234`	`+ }`
`230`	`235`	`}`