Skip to content

Commit 5b8abcb

Browse files
kossolaxdevelar
authored andcommitted
fix(nsis): Cloning packager.config to prevent override
This will fix the last issue of #1340 when targets artifact's names are changed. Close #1340
1 parent 39ae0a4 commit 5b8abcb

File tree

1 file changed

+2
-2
lines changed
  • packages/electron-builder/src/targets

1 file changed

+2
-2
lines changed

packages/electron-builder/src/targets/nsis.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export class NsisTarget extends Target {
8888

8989
this.packageHelper.refCount++
9090

91-
let options = this.packager.config.nsis || Object.create(null)
91+
let options = Object.assign({}, this.packager.config.nsis) || Object.create(null)
9292
if (targetName !== "nsis") {
9393
options = Object.assign(options, (<any>this.packager.config)[targetName === "nsis-web" ? "nsisWeb" : targetName])
9494
}
@@ -579,4 +579,4 @@ function computeCustomMessageTranslations(messages: any): Array<string> {
579579

580580
function createMacro(name: string, lines: Array<string>) {
581581
return `\n!macro ${name}\n ${lines.join("\n ")}\n!macroend\n`
582-
}
582+
}

0 commit comments

Comments
 (0)