Skip to content

Commit 5081536

Browse files
committed
fix(AppImage): fix AppImage build regression if max compression used
Close #2664
1 parent 3f6f5b6 commit 5081536

File tree

6 files changed

+25
-24
lines changed

6 files changed

+25
-24
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"////": "All typings are added into root `package.json` to avoid duplication errors in the IDE compiler (several `node.d.ts` files).",
3030
"dependencies": {
3131
"7zip-bin": "~3.1.0",
32-
"app-builder-bin": "1.7.0",
32+
"app-builder-bin": "1.7.1",
3333
"archiver": "^2.1.1",
3434
"async-exit-hook": "^2.0.1",
3535
"aws-sdk": "^2.205.0",
@@ -73,7 +73,7 @@
7373
"@types/ejs": "^2.5.0",
7474
"@types/electron-is-dev": "^0.3.0",
7575
"@types/ini": "^1.3.29",
76-
"@types/jest": "^22.1.4",
76+
"@types/jest": "^22.2.0",
7777
"@types/js-yaml": "^3.10.1",
7878
"@types/lodash.isequal": "^4.5.2",
7979
"@types/node-emoji": "^1.8.0",

packages/builder-util/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"out"
1212
],
1313
"dependencies": {
14-
"app-builder-bin": "1.7.0",
14+
"app-builder-bin": "1.7.1",
1515
"temp-file": "^3.1.1",
1616
"fs-extra-p": "^4.5.2",
1717
"is-ci": "^1.1.0",

packages/electron-builder-lib/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"homepage": "https://github.com/electron-userland/electron-builder",
4343
"dependencies": {
4444
"7zip-bin": "~3.1.0",
45-
"app-builder-bin": "1.7.0",
45+
"app-builder-bin": "1.7.1",
4646
"async-exit-hook": "^2.0.1",
4747
"bluebird-lst": "^1.0.5",
4848
"chromium-pickle-js": "^0.2.0",

test/out/linux/__snapshots__/linuxPackagerTest.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ Object {
7979
}
8080
`;
8181

82-
exports[`AppImage arm 1`] = `
82+
exports[`AppImage arm, max compression 1`] = `
8383
Object {
8484
"linux": Array [
8585
Object {

test/src/linux/linuxPackagerTest.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ test.ifAll.ifNotWindows.ifNotCiMac("AppImage ia32", app({
2727
},
2828
}))
2929

30-
test.ifAll.ifNotWindows.ifNotCiMac("AppImage arm", app({
30+
test.ifAll.ifNotWindows.ifNotCiMac("AppImage arm, max compression", app({
3131
targets: Platform.LINUX.createTarget("Appimage", Arch.armv7l),
3232
config: {
3333
publish: null,
34+
compression: "maximum",
3435
},
3536
}))
3637

yarn.lock

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,9 @@
112112
version "1.3.29"
113113
resolved "https://registry.yarnpkg.com/@types/ini/-/ini-1.3.29.tgz#1325e981e047d40d13ce0359b821475b97741d2f"
114114

115-
"@types/jest@^22.1.4":
116-
version "22.1.4"
117-
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-22.1.4.tgz#5c0c06a9bb495c67e0a78002a952f151e2ae58a1"
115+
"@types/jest@^22.2.0":
116+
version "22.2.0"
117+
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-22.2.0.tgz#55ce83139f7ad1b48b414c3927746614c6963c0f"
118118

119119
"@types/js-yaml@^3.10.1":
120120
version "3.10.1"
@@ -275,25 +275,25 @@ anymatch@^1.3.0:
275275
micromatch "^2.1.5"
276276
normalize-path "^2.0.0"
277277

278-
app-builder-bin-linux@1.7.0:
279-
version "1.7.0"
280-
resolved "https://registry.yarnpkg.com/app-builder-bin-linux/-/app-builder-bin-linux-1.7.0.tgz#83894c51e224382a7268997cc8af1283c1be21e3"
278+
app-builder-bin-linux@1.7.1:
279+
version "1.7.1"
280+
resolved "https://registry.yarnpkg.com/app-builder-bin-linux/-/app-builder-bin-linux-1.7.1.tgz#925967add77c13d387e3fe88359a4b4dce82c525"
281281

282-
app-builder-bin-mac@1.7.0:
283-
version "1.7.0"
284-
resolved "https://registry.yarnpkg.com/app-builder-bin-mac/-/app-builder-bin-mac-1.7.0.tgz#067a91d612fd3c2b687a097343ec4bb5f42c2e5f"
282+
app-builder-bin-mac@1.7.1:
283+
version "1.7.1"
284+
resolved "https://registry.yarnpkg.com/app-builder-bin-mac/-/app-builder-bin-mac-1.7.1.tgz#e5c2b49be82473a737e000cfccfc65a68f9cc62d"
285285

286-
app-builder-bin-win@1.7.0:
287-
version "1.7.0"
288-
resolved "https://registry.yarnpkg.com/app-builder-bin-win/-/app-builder-bin-win-1.7.0.tgz#caf81af88c5506717e4015880981b4ed3508414f"
286+
app-builder-bin-win@1.7.1:
287+
version "1.7.1"
288+
resolved "https://registry.yarnpkg.com/app-builder-bin-win/-/app-builder-bin-win-1.7.1.tgz#e1ba3d6d645896552b28e4dd05525b39561b9b88"
289289

290-
app-builder-bin@1.7.0:
291-
version "1.7.0"
292-
resolved "https://registry.yarnpkg.com/app-builder-bin/-/app-builder-bin-1.7.0.tgz#cb83e469d511f3516af7bca5288b692604bbd5c1"
290+
app-builder-bin@1.7.1:
291+
version "1.7.1"
292+
resolved "https://registry.yarnpkg.com/app-builder-bin/-/app-builder-bin-1.7.1.tgz#c2540eb8b164c91c30bc8cf3f16b5c181f3f5c31"
293293
optionalDependencies:
294-
app-builder-bin-linux "1.7.0"
295-
app-builder-bin-mac "1.7.0"
296-
app-builder-bin-win "1.7.0"
294+
app-builder-bin-linux "1.7.1"
295+
app-builder-bin-mac "1.7.1"
296+
app-builder-bin-win "1.7.1"
297297

298298
append-transform@^0.4.0:
299299
version "0.4.0"

0 commit comments

Comments
 (0)