fix: handle sync spawn error

develar · develar · commit 4351b569ce5d · 2017-04-16T11:29:40.000+02:00
Node http executor uses HTTPS agent. But! Electron http executor allows us to specify protocol in the options and by default uses `http`. So, we must **always** specify `protocol`. Close #1460
diff --git a/packages/electron-builder-http/src/httpExecutor.ts b/packages/electron-builder-http/src/httpExecutor.ts
@@ -297,6 +297,10 @@ export function configureRequestOptions(options: RequestOptions, token?: string
   if ((method == null || method === "GET") || headers["Cache-Control"] == null) {
     headers["Cache-Control"] = "no-cache"
   }
+
+  if (options.protocol == null) {
+    options.protocol = "https:"
+  }
   return options
 }
 

Original file line number	Diff line number	Diff line change
`@@ -297,6 +297,10 @@ export function configureRequestOptions(options: RequestOptions, token?: string`
`297`	`297`	`if ((method == null \|\| method === "GET") \|\| headers["Cache-Control"] == null) {`
`298`	`298`	`headers["Cache-Control"] = "no-cache"`
`299`	`299`	`}`
	`300`	`+`
	`301`	`+ if (options.protocol == null) {`
	`302`	`+ options.protocol = "https:"`
	`303`	`+ }`
`300`	`304`	`return options`
`301`	`305`	`}`
`302`	`306`